[GitHub] [calcite] neoremind commented on issue #1875: [CALCITE-3873] Use global caching for ReflectiveVisitDispatcher implementation

[GitBox]

neoremind commented on issue #1875: [CALCITE-3873] Use global caching for 
ReflectiveVisitDispatcher implementation
URL: https://github.com/apache/calcite/pull/1875#issuecomment-607112581
 
 
   @vlsi I replied my your comment in the code review section above. 
   PS. There are global caches existing like below, all of them reachable, 
except that the`Integer.MAX_VALUE` limit might exhaust memory.
   ```
   public static final CalciteSystemProperty<Integer> 
METADATA_HANDLER_CACHE_MAXIMUM_SIZE =
         intProperty("calcite.metadata.handler.cache.maximum.size", 1000);
   public static final CalciteSystemProperty<Integer> BINDABLE_CACHE_MAX_SIZE =
     intProperty("calcite.bindable.cache.maxSize", 0, v -> v >= 0 && v <= 
Integer.MAX_VALUE);
   ```
    

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services