hsyuan commented on a change in pull request #1883: [CALCITE-3833] Support
SemiJoin in EnumerableMergeJoin
URL: https://github.com/apache/calcite/pull/1883#discussion_r402361729
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -1971,8 +1973,42 @@ private void closeInner() {
final Function2<TSource, TInner, TResult> resultSelector,
boolean generateNullsOnLeft,
boolean generateNullsOnRight) {
+ if (generateNullsOnLeft) {
+ throw new UnsupportedOperationException(
+ "not implemented, mergeJoin with generateNullsOnLeft");
+ }
+ if (generateNullsOnRight) {
+ throw new UnsupportedOperationException(
+ "not implemented, mergeJoin with generateNullsOnRight");
+ }
+ return mergeJoin(outer, inner, outerKeySelector, innerKeySelector, null,
resultSelector,
+ JoinType.INNER, null);
+ }
+
+ public static boolean isMergeJoinSupported(JoinType joinType) {
Review comment:
Can we add a note that this method is subject to change or remove without
notice?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
