DonnyZone commented on a change in pull request #1896: 3877, 3892, 3814 and 3876
URL: https://github.com/apache/calcite/pull/1896#discussion_r402717219
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -1439,6 +1439,14 @@ private boolean needNewSubQuery(RelNode rel, Clause[]
clauses) {
return true;
}
+ if (rel instanceof Project
Review comment:
Do we also need to prevent merging projects in RelBuilder when converting
`SqlNode` to `RelNode`?
```
LogicalProject(EXPR$0=[ROW_NUMBER() OVER (ORDER BY ROW_NUMBER() OVER (ORDER
BY $1 ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW) ROWS BETWEEN UNBOUNDED
PRECEDING AND CURRENT ROW)])
JdbcTableScan(table=[[foodmart, product]])
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
