julianhyde commented on a change in pull request #1896: 3877, 3892, 3814 and 3876 URL: https://github.com/apache/calcite/pull/1896#discussion_r403402028
########## File path: babel/src/test/resources/sql/redshift.iq ########## @@ -603,11 +603,11 @@ EMPNO, EXPR$1 select dense_rank() over () from emp where deptno = 30; EXPR$0 6 -6 -6 -6 -6 -6 +1 Review comment: I don't know. Since this is babel, the main point of the test is parsing & validation, not execution. I don't much care if the results are wrong. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
