vlsi commented on a change in pull request #1896: 3877, 3892, 3814 and 3876
URL: https://github.com/apache/calcite/pull/1896#discussion_r403435923
##########
File path: core/src/main/java/org/apache/calcite/schema/Schemas.java
##########
@@ -224,15 +224,15 @@ public static DataContext createDataContext(
* array. */
public static Enumerable<Object[]> enumerable(final FilterableTable table,
final DataContext root) {
- return table.scan(root, ImmutableList.of());
+ return table.scan(root, new ArrayList<>());
Review comment:
javadoc does not say the implementation can **add** new filters to the list.
So `Collections.emptyList()` is fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
