danny0405 commented on a change in pull request #1900: [CALCITE-3733] MySQL 
JDBC rewrite should rewrite CAST as TIMESTAMP to CAST as DATETIME (Vineet Garg)
URL: https://github.com/apache/calcite/pull/1900#discussion_r405244213
 
 

 ##########
 File path: 
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
 ##########
 @@ -1834,6 +1834,18 @@ private static String toSql(RelNode root, SqlDialect 
dialect) {
     sql(query).withMysql().ok(expected);
   }
 
+  @Test void testMySqlCastToTimestamp() {
+    //final String query = "select cast(\"hire_date\" as TIMESTAMP), 
\"employee_id\" "
+     //   + "from \"employee\" ";
+    //final String expected = "select cast(\"hire_date\" as DATE_TIME), 
\"employee_id\" "
 
 Review comment:
   Remove the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to