my7ym commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r405954347
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -7540,6 +7540,47 @@ public void _testGroupExpressionEquivalenceParams() {
.fails("Column 'C1' not found in any table");
}
+ /**
Review comment:
Remove duplicate-purposed tests, add comments, and add negative cases. Did
not break up method since it seems to be not the convention in this test class.
And also debating on how to name those tests, whether
testAliasUnneestMultipleArrays_forXXX or testAliasUnneestMultipleArraysForXXX
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
