jinxing64 commented on a change in pull request #1926:
URL: https://github.com/apache/calcite/pull/1926#discussion_r411107920
##########
File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java
##########
@@ -36,11 +36,12 @@ public static MutableScan of(TableScan scan) {
@Override public boolean equals(Object obj) {
return obj == this
|| obj instanceof MutableScan
- && rel.equals(((MutableScan) obj).rel);
+ && rel.getTable().getQualifiedName().equals(((MutableScan) obj).rel
Review comment:
Hi @DonnyZone Thanks a lot for looking into this !
There's a discussion for overriding `equals()&hashCode()` in
https://issues.apache.org/jira/browse/CALCITE-3167
The conclusion is to make `equals()&hashCode()` final in `AbstractRelNode `
and have independent mechanisms to define the equality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
