amaliujia commented on a change in pull request #1761:
URL: https://github.com/apache/calcite/pull/1761#discussion_r412344527
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -2296,8 +2298,14 @@ public void unparse(
/** DESCRIPTOR(column_name, ...). */
public static final SqlOperator DESCRIPTOR = new SqlDescriptorOperator();
- /** TUMBLE as a table-value function. */
- public static final SqlFunction TUMBLE_TVF = new
SqlWindowTableFunction(SqlKind.TUMBLE.name());
+ /** TUMBLE as a table function. */
+ public static final SqlFunction TUMBLE_TVF = new SqlTumbleTableFunction();
+
+ /** HOP as a table function. */
+ public static final SqlFunction HOP_TVF = new SqlHopTableFunction();
+
+ /** SESSION as a table function. */
+ public static final SqlFunction SESSION_TVF = new SqlSessionTableFunction();
Review comment:
After a second thought, I think I will just make the change about "HOP"
and "_HOP" for old and new in this PR, because as you have said, I have already
used "$" in the name.
The email discussion I want is about a bigger discussion on if we should
fully deprecate group window function. I will do it later and that discussion
is not relevant to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
