hsyuan commented on a change in pull request #1912:
URL: https://github.com/apache/calcite/pull/1912#discussion_r412635449
##########
File path: core/src/main/java/org/apache/calcite/plan/RelTrait.java
##########
@@ -85,4 +87,14 @@
* @param planner Planner
*/
void register(RelOptPlanner planner);
+
+ /**
+ * Applies a mapping to this trait.
+ *
+ * @param mapping Mapping
+ * @return trait with mapping applied
+ */
+ default <T extends RelTrait> T apply(Mappings.TargetMapping mapping) {
Review comment:
Hi @rkondakov, I know the mappings is confusing. But I searched around,
didn't find any uses other than TargetMapping. I will leave it TargetMapping as
it is, but we can add other once we found there is a need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
