xy2953396112 commented on a change in pull request #1936:
URL: https://github.com/apache/calcite/pull/1936#discussion_r412745003
##########
File path:
core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -223,6 +228,19 @@
return new SubstitutionVisitor(target, root).go(materialization.tableRel);
}
+ /**
+ * trim unused fields in relational expressions.
+ */
+ private static RelNode trimUnusedfields(RelNode relNode) {
+ final List<RelOptTable> relOptTables = RelOptUtil.findAllTables(relNode);
Review comment:
yeah, you are right, if there's no TableScan, it will return itself.
##########
File path:
core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -223,6 +228,19 @@
return new SubstitutionVisitor(target, root).go(materialization.tableRel);
}
+ /**
+ * trim unused fields in relational expressions.
Review comment:
Thanks , will update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
