rkondakov commented on a change in pull request #1959:
URL: https://github.com/apache/calcite/pull/1959#discussion_r419456514
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -135,10 +140,16 @@ public RelDistribution apply(Mappings.TargetMapping
mapping) {
if (keys.isEmpty()) {
return this;
}
- return getTraitDef().canonize(
- new RelDistributionImpl(type,
- ImmutableIntList.copyOf(
- Mappings.apply2((Mapping) mapping, keys))));
+ List<Integer> mapList = Mappings.asList(mapping);
+ for (Integer key : keys) {
Review comment:
I replaced `Mappings.asList(mapping)` with `mapping.getTargetOpt(key)`,
please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
