hsyuan commented on a change in pull request #1737:
URL: https://github.com/apache/calcite/pull/1737#discussion_r419818253
##########
File path: core/src/main/java/org/apache/calcite/interpreter/Bindables.java
##########
@@ -517,29 +521,50 @@ public Node implement(InterpreterImplementor implementor)
{
}
}
- /**
- * Rule to convert an {@link org.apache.calcite.rel.logical.LogicalUnion}
- * to a {@link BindableUnion}.
- */
- public static class BindableUnionRule extends ConverterRule {
+ @Deprecated // use BindableSetOpRule instead
+ public static class BindableUnionRule extends BindableSetOpRule {
/**
* Creates a BindableUnionRule.
*
* @param relBuilderFactory Builder for relational expressions
*/
public BindableUnionRule(RelBuilderFactory relBuilderFactory) {
Review comment:
Can we remove this constructor if possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
