hsyuan commented on pull request #1918:
URL: https://github.com/apache/calcite/pull/1918#issuecomment-624084388


   I am afraid 2970 won't finish soon. @rubenada Can you take a look at my 
patch and bring useful ideas you think back to your patch? 
https://github.com/hsyuan/calcite/commit/5365272fdd69fd4ca4d3356e7c640b17e243c6d3
   
   I don't like the fix, which looks hacky, but it should work. The more 
thorough fix is logical operator should not have traits and drop 
RelCompositeTrait completely. They are useless, and have caused so many bugs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to