danny0405 commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r422580707
##########
File path: core/src/main/java/org/apache/calcite/plan/Convention.java
##########
@@ -66,6 +67,13 @@ default boolean
useAbstractConvertersForConversion(RelTraitSet fromTraits,
return false;
}
+ /**
+ * Return RelFactories struct for the convention which can be used to build
RelNode
+ */
+ default RelFactories.Struct getRelFactories() {
+ return RelFactories.DEFAULT_STRUCT;
+ }
Review comment:
Instead of add a `getRelFactories` interface to Convention, how about
add a tool method `RelFactories#getRelFactories(Convention)`, it seems more
straight forward because `RelFactories` is the factory to create all kinds of
factory STRUCT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
