DonnyZone commented on a change in pull request #1971:
URL: https://github.com/apache/calcite/pull/1971#discussion_r422759894
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -1166,9 +1170,22 @@ private static Expression implementNullSemantics(
default:
throw new AssertionError();
}
+
+ // Condition for regular cases: v0 == null || v1 == null
+ Expression condition = Expressions.foldOr(list);
+ if (nullPolicy == NullPolicy.ALL) {
+ // if some operands are not nullable ROW can not be null
Review comment:
To unify the comment style, capitalize `if` as `If`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
