xy2953396112 commented on a change in pull request #1988:
URL: https://github.com/apache/calcite/pull/1988#discussion_r430880649
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlInsert.java
##########
@@ -62,7 +62,11 @@ public SqlOperator getOperator() {
}
public List<SqlNode> getOperandList() {
- return ImmutableNullableList.of(keywords, targetTable, source, columnList);
+ if (columnList == null) {
Review comment:
@DonnyZone Thansk for review. targetTable and source should be not null.
For example a sql such as `insert into emps` , it can’t be parsed.
`insert into emps VALUES (true, 1)` be parsed as SqlInsert, source not null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
