amaliujia commented on a change in pull request #1991: URL: https://github.com/apache/calcite/pull/1991#discussion_r432883073
########## File path: core/src/main/java/org/apache/calcite/config/CalciteConnectionProperty.java ########## @@ -105,6 +105,10 @@ * {@link org.apache.calcite.sql.parser.SqlParserImplFactory}. */ PARSER_FACTORY("parserFactory", Type.PLUGIN, null, false), + /** Specifies whether to use top down optimization. + * {@link org.apache.calcite.plan.volcano.VolcanoPlanner#setTopDownOpt(boolean)} */ + TOP_DOWN_OPT("topDownOpt", Type.BOOLEAN, true, false), Review comment: I think you need a rebase to master. The similar code was already added in https://github.com/apache/calcite/pull/1985 ########## File path: core/src/main/java/org/apache/calcite/config/CalciteConnectionProperty.java ########## @@ -105,6 +105,10 @@ * {@link org.apache.calcite.sql.parser.SqlParserImplFactory}. */ PARSER_FACTORY("parserFactory", Type.PLUGIN, null, false), + /** Specifies whether to use top down optimization. + * {@link org.apache.calcite.plan.volcano.VolcanoPlanner#setTopDownOpt(boolean)} */ + TOP_DOWN_OPT("topDownOpt", Type.BOOLEAN, true, false), Review comment: I think you need a rebase on master. The similar code was already added in https://github.com/apache/calcite/pull/1985 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org