FatLittle commented on a change in pull request #1991:
URL: https://github.com/apache/calcite/pull/1991#discussion_r433596256
##########
File path:
core/src/main/java/org/apache/calcite/config/CalciteConnectionProperty.java
##########
@@ -105,6 +105,10 @@
* {@link org.apache.calcite.sql.parser.SqlParserImplFactory}. */
PARSER_FACTORY("parserFactory", Type.PLUGIN, null, false),
+ /** Specifies whether to use top down optimization.
+ * {@link
org.apache.calcite.plan.volcano.VolcanoPlanner#setTopDownOpt(boolean)} */
+ TOP_DOWN_OPT("topDownOpt", Type.BOOLEAN, true, false),
Review comment:
IMHO, if we ignore those plan changes every time we commit code, the
code is more vulnerable to bugs. And it will be even harder to fix plan changes
in the future as we don't know which and whose commit introduced the plan
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
