jinxing64 commented on a change in pull request #2000:
URL: https://github.com/apache/calcite/pull/2000#discussion_r435120198



##########
File path: 
core/src/test/java/org/apache/calcite/test/MaterializedViewSubstitutionVisitorTest.java
##########
@@ -410,6 +410,21 @@
     sql(mv, query).noMat();
   }
 
+  /**
+   * stddev_pop aggregate function does not support roll up.
+   */
+  @Test public void testSqlAggFunctionRollup() {

Review comment:
       In current `MaterializedViewSubstitutionVisitorTest.java`, there's 
already an `testAggregateRollUp`. How about rename this as 
`testSqlAggFunctionRollup2` and put it after `testAggregateRollUp` ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to