amaliujia commented on pull request #1995: URL: https://github.com/apache/calcite/pull/1995#issuecomment-639279517
@hsyuan I have push commits for collation pushdown for both EnumerableHashJoin and EnumerableNestedLoopJoin. Regarding traits derivation, I gave some thoughts on it and now I think it is not useful. It is because for both EnumerableHashJoin and EnumerableNestedLoopJoin, they can perserve ordering from left join input. Based on examples of MergeJoin, seems like the goal of trait derivation was to enforce a sort on right input, which does not work for hashjoin and nested loop join in this case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
