rubenada commented on a change in pull request #2015:
URL: https://github.com/apache/calcite/pull/2015#discussion_r438656521
##########
File path:
core/src/test/java/org/apache/calcite/sql2rel/RelFieldTrimmerTest.java
##########
@@ -183,4 +187,44 @@
assertThat(trimmed, hasTree(expected));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-4055";>[CALCITE-4055]
+ * RelFieldTrimmer loses hints</a>. */
+ @Test void testJoinWithHints() {
+ final RelHint noHashJoinHint = RelHint.builder("NO_HASH_JOIN").build();
+ final RelBuilder builder = RelBuilder.create(config().build());
Review comment:
Disregard my question, I already saw what you mean "if the passed in
hints is empty, just returns the builder early". Ok, I will do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
