amaliujia commented on a change in pull request #2023:
URL: https://github.com/apache/calcite/pull/2023#discussion_r439577517
##########
File path: core/src/test/java/org/apache/calcite/test/TopDownOptTest.java
##########
@@ -693,6 +678,37 @@
.removeRule(EnumerableRules.ENUMERABLE_JOIN_RULE)
.check();
}
+
+ // push sort to left input
+ @Test void testBatchNestedLoopJoinLeftOuterJoinPushDownSort() {
Review comment:
Not adding too many tests for EnumerableBatchNestedLoopJoin because it
reuses EnumerableNestedLoopJoin's code and those code was tested.
Add two test only to verify that trait propagation in
EnumerableBatchNestedLoopJoin is working.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
