bozzzzo commented on pull request #2025: URL: https://github.com/apache/calcite/pull/2025#issuecomment-643825132
Thank you for having a look at this! [Here](https://github.com/bozzzzo/calcite/commit/cd966361f23c41d5f987a2b7ab85b60a1731df10) is a patch for the `unparse` tests that shows the `UNNEST` is now indeed behaving correctly. The above shows that `MATCH_RECOGNIZE` tests fail in a suspiciously similar way due to extra parentheses (if I read the exception correctly, I'm not familiar with `MATCH_RECOGNIZE` syntax) What I found is that there is a class `SqlFunctionCategory` that already marks `MATCH_RECOGNIZE` as a `TABLE_FUNCTION`. Could a better fix be made by adding `UNNEST` to the `SqlFunctionCategory` and then one could check the `isTableFunction()` instead of hardcoding a check for `SqlUnnestOperator`. There is a missing link in my approach that `SqlUnnestOperator` does not derive or implement anything that would expose the `SqlFunctionCategory` which seems a pity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
