danny0405 commented on a change in pull request #1990:
URL: https://github.com/apache/calcite/pull/1990#discussion_r440130813
##########
File path: core/src/main/java/org/apache/calcite/util/DateTimeStringUtils.java
##########
@@ -25,6 +29,15 @@
private DateTimeStringUtils() {}
+ /** The SimpleDateFormat string for ISO timestamps,
"yyyy-MM-dd'T'HH:mm:ss'Z'"*/
+ public static final String TIMESTAMP_FORMAT_STRING1 =
+ "yyyy-MM-dd'T'HH:mm:ss'Z'";
+
+ /** The SimpleDateFormat string for ISO timestamps with precisions,
"yyyy-MM-dd'T'HH:mm:ss
+ * .SSS'Z'"*/
+ public static final String TIMESTAMP_FORMAT_STRING2 =
+ "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'";
Review comment:
Can we use more readable name for these formats ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
