danny0405 commented on a change in pull request #2016:
URL: https://github.com/apache/calcite/pull/2016#discussion_r442608886
##########
File path: core/src/main/java/org/apache/calcite/plan/hep/HepRelVertex.java
##########
@@ -75,8 +76,8 @@
return currentRel.getRowType();
}
- @Override protected String computeDigest() {
- return "HepRelVertex(" + currentRel + ")";
+ @Override protected Digest computeDigest() {
+ return Digest.create(this, getRelTypeName() + '#' +
getCurrentRel().getId());
}
Review comment:
To unify the logic, we can switch to "HepRelVertex", that's a preference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
