xy2953396112 commented on a change in pull request #2021:
URL: https://github.com/apache/calcite/pull/2021#discussion_r446503752



##########
File path: core/src/test/java/org/apache/calcite/test/MockSqlOperatorTable.java
##########
@@ -125,6 +125,18 @@ public RelDataType inferReturnType(SqlOperatorBinding 
opBinding) {
     }
   }
 
+  /** "MYAGGFUNC" user-defined aggregate function. This agg function accept 
one or more arguments
+   * in order to reproduce the throws of CALCITE-3929. */
+  public static class MyAggFunc extends SqlAggFunction {

Review comment:
       @yanlin-Lynn
   Thanks, `SqlUserDefinedAggFunction`  has an AggregateFunction argument, it's 
not convenient for reproduce this case.So it's better to extends SqlAggFunction 
and define it as a user-defined function.
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to