julianhyde opened a new pull request #2047:
URL: https://github.com/apache/calcite/pull/2047


   In order to fix https://issues.apache.org/jira/browse/CALCITE-3936, we 
needed significant refactoring of `SqlImplementor` and `RelToSqlConverter`.
   
   There are various changes to the signatures of protected methods; I don't 
consider them public APIs: Renamed `SqlImplementor.visitChild` to `visitInput`, 
replaced `Sqlmplementor.Result.builder(RelNode, Clause...)` with two methods, 
`builder(RelNode)` and `builder(RelNode, Clause, Clause...)`, the latter of 
which is deprecated.
   
   The changes have not yet been squashed, and incorrectly reference 
CALCITE-3896; should be CALCITE-3936.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to