zinking commented on pull request #1944: URL: https://github.com/apache/calcite/pull/1944#issuecomment-652379106
> > I don't see interface definition needs to be changed, the change should be made in the IMPlementation file. > > @zinking Thanks for your good suggestion. I have reverted the changes to the interface. I'm sorry, I think I changed my mind after seeing the second implementation file. I do remember I deleted my comment after that though. so your original default implementation is indeed better, because less code and high coupling. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
