Aaaaaaron commented on a change in pull request #2019:
URL: https://github.com/apache/calcite/pull/2019#discussion_r448732591



##########
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java
##########
@@ -117,6 +120,34 @@
     SqlTypeCoercionRule.THREAD_PROVIDERS.set(defaultRules);
   }
 
+  @Test void testEqualAsCollectionSansNullability() {
+    final SqlTypeFactoryImpl factory =
+        new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);
+
+    // case array
+    assertThat(
+        equalAsCollectionSansNullability(factory, f.arrayBigInt, 
f.arrayBigIntNullable),
+        is(true));
+
+    // case multiset
+    assertThat(
+        equalAsCollectionSansNullability(factory, f.multisetBigInt, 
f.multisetBigIntNullable),
+        is(true));
+
+    // multiset and array are not equal.
+    assertThat(
+        equalAsCollectionSansNullability(factory, f.arrayBigInt, 
f.multisetBigInt),
+        is(false));
+  }
+
+  @Test void testEqualAsMapSansNullability() {
+    final SqlTypeFactoryImpl factory =
+        new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);
+

Review comment:
       Thanks for your suggestion, updated already.
   
   

##########
File path: core/src/test/java/org/apache/calcite/sql/type/SqlTypeUtilTest.java
##########
@@ -117,6 +120,34 @@
     SqlTypeCoercionRule.THREAD_PROVIDERS.set(defaultRules);
   }
 
+  @Test void testEqualAsCollectionSansNullability() {
+    final SqlTypeFactoryImpl factory =
+        new SqlTypeFactoryImpl(RelDataTypeSystem.DEFAULT);

Review comment:
       Thanks for your suggestion, updated already.
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to