FatLittle commented on a change in pull request #1991:
URL: https://github.com/apache/calcite/pull/1991#discussion_r451941971
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -839,6 +806,67 @@ RelNode changeTraitsUsingConverters(
prunedNodes.add(rel);
}
+
+ /** Returns whether to skip a match. This happens if any of the
+ * {@link RelNode}s have importance zero. */
+ boolean skipMatch(VolcanoRuleMatch match) {
Review comment:
1. Currently, the planner is in charge of matching rules and pruning
nodes (by importances or other mechanism). So I think it is more natural that
planner judges whether a rule match is validate or not.
2. By moving to Planner, it could be easier to overwrite the logic by users,
adding customized pruning logic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
