hsyuan commented on a change in pull request #2065:
URL: https://github.com/apache/calcite/pull/2065#discussion_r456170450
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlOperator.java
##########
@@ -929,6 +929,17 @@ public boolean isDeterministic() {
return true;
}
+ /**
+ * Returns whether a call to this operator is not sensitive to the operands
input order.
+ * An operator is symmetrical if the call returns the same result when
+ * the operands are shuffled.
+ *
+ * <p>By default, returns true for {@link SqlKind#SYMMETRICAL}.
+ */
+ public boolean isSymmetrical() {
+ return SqlKind.SYMMETRICAL.contains(kind);
Review comment:
So would you rather believe that Scala guys are always right, even when
the dictionary clearly says otherwise?
I do believe you have the common sense of what symmetric encryption
algorithm is.
FYI, the original method name of `MurmurHash3#unorderedHash` was
`symmetricHash`, it was later
[renamed](https://github.com/scala/scala/commit/60fb9ec19b50cd8059122ccffd72014b3eefc51f#diff-1c768a8500fbe02dc18f6333be992081R98)
to `unorderedHash`, but the author forgot to update the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
