hsyuan commented on a change in pull request #2074:
URL: https://github.com/apache/calcite/pull/2074#discussion_r457014805
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Filter.java
##########
@@ -166,13 +166,13 @@ protected boolean digestEquals0(Object obj) {
}
Filter o = (Filter) obj;
return traitSet.equals(o.traitSet)
- && input.equals(o.input)
+ && input.digestEquals(o.input)
&& condition.equals(o.condition)
&& getRowType().equalsSansFieldNames(o.getRowType());
}
@API(since = "1.24", status = API.Status.INTERNAL)
protected int digestHash0() {
- return Objects.hash(traitSet, input, condition);
+ return Objects.hash(traitSet, input.digestHash(), condition);
Review comment:
If we can change RelNode#hashCode(), everything will be normal. I am
happy to remove digestHash() if we can remove final from hashCode().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
