julianhyde commented on pull request #1057: URL: https://github.com/apache/calcite/pull/1057#issuecomment-660790223
The new commit message 'Codegen compile error for decimal nagate' seems worse: * 'nagate' is not a word * 'decimal' is lower-case so I don't know whether you mean the SQL DECIMAL type of the java BigDecimal type * It doesn't indicate the cause of the problem (i.e. under what circumstances a user could hit this). "Support decimalNegate function" is useless javadoc. Why do we need a "decimalNegate" function? Why not call `BigDecimal.negate()` directly? Most functions in SqlFunctions directly implement SQL operators. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
