danny0405 commented on a change in pull request #2073:
URL: https://github.com/apache/calcite/pull/2073#discussion_r459191316
##########
File path: core/src/test/java/org/apache/calcite/test/CalciteAssert.java
##########
@@ -1830,19 +1830,19 @@ public AssertQuery withRel(final Function<RelBuilder,
RelNode> relFn) {
return withHook(Hook.STRING_TO_QUERY,
(Consumer<Pair<FrameworkConfig, Holder<CalcitePrepare.Query>>>)
pair -> {
- final FrameworkConfig config = forceDecorrelate(pair.left);
+ final FrameworkConfig config = withDecorrelate(pair.left, false);
final RelBuilder b = RelBuilder.create(config);
pair.right.set(CalcitePrepare.Query.of(relFn.apply(b)));
});
}
/** Creates a {@link FrameworkConfig} that does not decorrelate. */
- private FrameworkConfig forceDecorrelate(FrameworkConfig config) {
+ private FrameworkConfig withDecorrelate(FrameworkConfig config, boolean
needDecorrelate) {
return Frameworks.newConfigBuilder(config)
Review comment:
How about just remove the method and inline the code, the method name is
mis-leading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
