hsyuan commented on a change in pull request #2076:
URL: https://github.com/apache/calcite/pull/2076#discussion_r460609784
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/IterativeRuleQueue.java
##########
@@ -43,56 +40,21 @@
private static final Logger LOGGER = CalciteTrace.getPlannerTracer();
- private static final Set<String> ALL_RULES = ImmutableSet.of("<ALL RULES>");
-
//~ Instance fields --------------------------------------------------------
/**
- * Map of {@link VolcanoPlannerPhase} to a list of rule-matches. Initially,
- * there is an empty {@link PhaseMatchList} for each planner phase. As the
+ * A list of rule-matches.
+ * Initially, there is an empty {@link MatchList}. As the
* planner invokes {@link #addMatch(VolcanoRuleMatch)} the rule-match is
- * added to the appropriate PhaseMatchList(s). As the planner completes
- * phases, the matching entry is removed from this list to avoid unused
- * work.
- */
- final Map<VolcanoPlannerPhase, PhaseMatchList> matchListMap =
- new EnumMap<>(VolcanoPlannerPhase.class);
-
- /**
- * Maps a {@link VolcanoPlannerPhase} to a set of rule descriptions. Named
rules
- * may be invoked in their corresponding phase.
- *
- * <p>See {@link VolcanoPlannerPhaseRuleMappingInitializer} for more
- * information regarding the contents of this Map and how it is initialized.
+ * added to the appropriate MatchList(s). As the planner completes the match,
+ * the matching entry is removed from this list to avoid unused work.
*/
- private final Map<VolcanoPlannerPhase, Set<String>> phaseRuleMapping;
Review comment:
You have to keep the set, to avoid duplicate rulematch adding into the
queue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
