F21 commented on a change in pull request #53:
URL: https://github.com/apache/calcite-avatica-go/pull/53#discussion_r462647404
##########
File path: docker.sh
##########
@@ -205,10 +205,10 @@ check_if_tag_exists(){
check_local_remote_are_even(){
REMOTE_COMMIT=$(git ls-remote $GITBOX_URL | head -1 | sed
"s/[[:space:]]HEAD//")
- LOCAL_COMMIT=$(git rev-parse master)
+ LOCAL_COMMIT=$(git rev-parse main)
if [[ $REMOTE_COMMIT != $LOCAL_COMMIT ]]; then
- echo "Master in Apache repository is not even with local master"
+ echo "Master in Apache repository is not even with local main"
Review comment:
I think `Master` should also be replaced here :)
##########
File path: docker.sh
##########
@@ -205,10 +205,10 @@ check_if_tag_exists(){
check_local_remote_are_even(){
REMOTE_COMMIT=$(git ls-remote $GITBOX_URL | head -1 | sed
"s/[[:space:]]HEAD//")
- LOCAL_COMMIT=$(git rev-parse master)
+ LOCAL_COMMIT=$(git rev-parse main)
if [[ $REMOTE_COMMIT != $LOCAL_COMMIT ]]; then
- echo "Master in Apache repository is not even with local master"
+ echo "Master in Apache repository is not even with local main"
Review comment:
@michaelmior I think `Master` should also be replaced here :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
