chunweilei commented on a change in pull request #2107:
URL: https://github.com/apache/calcite/pull/2107#discussion_r471875498
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -4223,8 +4227,10 @@ private boolean advanceLeft(TSource left, TKey leftKey) {
TKey leftKey2 = outerKeySelector.apply(left);
if (leftKey2 == null) {
// mergeJoin assumes inputs sorted in ascending order with nulls
last,
- // if we reach a null key, we are done
- break;
+ // if we reach a null key, we are done (except LEFT join, that needs
to process LHS fully)
+ if (joinType != JoinType.LEFT) {
+ break;
+ }
}
Review comment:
Could we merge these two if conditions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
