thomasrebele commented on a change in pull request #2109:
URL: https://github.com/apache/calcite/pull/2109#discussion_r472135871
##########
File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
##########
@@ -1039,6 +1039,54 @@ private void
basePushFilterPastAggWithGroupingSets(boolean unchanged) {
.check();
}
+ /**
+ * Test if limit and sort are replaced by a limit sort.
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-3920";>[CALCITE-3920]
+ * Improve ORDER BY computation in Enumerable convention by exploiting
LIMIT</a>.
+ */
+ @Test void testLimitSort() {
+ final String sql = "select mgr from sales.emp\n"
+ + "union select mgr from sales.emp\n"
+ + "order by mgr limit 10 offset 5";
+
+ VolcanoPlanner planner = new VolcanoPlanner(null, null);
+ planner.addRelTraitDef(ConventionTraitDef.INSTANCE);
+ RelOptUtil.registerDefaultRules(planner, false, false);
+ planner.addRule(EnumerableRules.ENUMERABLE_LIMIT_SORT_RULE);
+
+ Tester tester = createTester().withDecorrelation(true)
+ .withClusterFactory(
+ relOptCluster -> RelOptCluster.create(planner,
relOptCluster.getRexBuilder()));
+
+ RelRoot root = tester.convertSqlToRel(sql);
+
+ String planBefore = NL + RelOptUtil.toString(root.rel);
+ getDiffRepos().assertEquals("planBefore", "${planBefore}", planBefore);
+
+ RuleSet ruleSet =
+ RuleSets.ofList(
+ EnumerableRules.ENUMERABLE_SORT_RULE,
+ EnumerableRules.ENUMERABLE_LIMIT_RULE,
+ EnumerableRules.ENUMERABLE_LIMIT_SORT_RULE,
Review comment:
Yes, to check whether the new operator is chosen correctly. A plan with
EnumerableLimit(EnumerableSort(...)) should have a higher cost.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
