julianhyde commented on a change in pull request #2111:
URL: https://github.com/apache/calcite/pull/2111#discussion_r474186421



##########
File path: 
core/src/main/java/org/apache/calcite/rel/RelReferentialConstraint.java
##########
@@ -27,10 +27,13 @@
 public interface RelReferentialConstraint {
   //~ Methods ----------------------------------------------------------------
 
-  /**
-   * Returns the number of columns in the keys.
-   */
-  int getNumColumns();
+  /** Returns the number of columns in the keys.
+   *
+   * @deprecated Use {@code getColumnPairs().size()} */
+  @Deprecated // to be removed before 2.0
+  default int getNumColumns() {
+    return getColumnPairs().size();
+  }

Review comment:
       We need to put breaking changes in the release notes but I don't regard 
deprecations as breaking changes.
   
   I've moved this change (and related changes in `MaterializedViewRule`) into 
a 'refactor' commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to