rubenada commented on a change in pull request #2006:
URL: https://github.com/apache/calcite/pull/2006#discussion_r475448937
##########
File path: core/src/test/java/org/apache/calcite/rel/RelCollationTest.java
##########
@@ -84,18 +84,36 @@
is(true));
}
- /** Unit test for {@link RelCollations#containsOrderless(List, List)}. */
+ /** Unit test for {@link RelCollations#collationsContainKeysOrderless(List,
List)}. */
Review comment:
maybe we could also add some unit tests for the new method
`keysContainCollationsOrderless`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
