angelzouxin commented on a change in pull request #2116:
URL: https://github.com/apache/calcite/pull/2116#discussion_r476155337
##########
File path:
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcToEnumerableConverter.java
##########
@@ -195,7 +235,14 @@ public Result implement(EnumerableRelImplementor
implementor, Prefer pref) {
}
private List<ConstantExpression> toIndexesTableExpression(SqlString
sqlString) {
- return sqlString.getDynamicParameters().stream()
+ return
Optional.ofNullable(sqlString.getDynamicParameters()).orElse(ImmutableList.of()).stream()
+ .map(Expressions::constant)
+ .collect(Collectors.toList());
+ }
+
+ private List<ConstantExpression> toIndexCorrelateExpression(SqlString
sqlString,
+ StringBuilder querySqlSb, SqlDialect sqlDialect) {
+ return sqlDialect.getDynamicTypeIndexs(querySqlSb,
sqlString.getSql()).stream()
Review comment:
you're right, i changed the implementation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
