vlsi commented on a change in pull request #127:
URL: https://github.com/apache/calcite-avatica/pull/127#discussion_r477604972
##########
File path: .gitignore
##########
@@ -22,3 +22,4 @@ settings.xml
/target/
/*/target/
/shaded/*/target/
+bin
Review comment:
This would ignore all bin folders in all subfolders (e.g. it would
ignore `org.apache.calcite.encodings.bin....` folder if one is created). Do you
intend that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
