yanlin-Lynn commented on a change in pull request #2110:
URL: https://github.com/apache/calcite/pull/2110#discussion_r479777370
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -678,7 +678,8 @@ SqlOperator toOp(Map<String, Object> map) {
if (class_ != null) {
return AvaticaUtils.instantiatePlugin(SqlOperator.class, class_);
}
- return null;
+ throw new RuntimeException("No operator for " + name + " with kind: "
+ + kind + ", and syntax: " + syntax);
Review comment:
Yes, this breaks a little. I don't know the background why it returns
null before.
Hopes someone can help to give the background, but I doubt there exists some
special reason, because null will always cause NPE somewhere else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
