danny0405 commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r481931734
##########
File path: core/src/main/java/org/apache/calcite/rex/RexUtil.java
##########
@@ -2833,4 +2898,77 @@ public boolean anyContain(Iterable<? extends RexNode>
nodes) {
}
}
+ /** Converts a {@link Range} to a {@link RexNode} expression.
+ *
+ * @param <C> Value type */
+ private static class RangeToRex<C extends Comparable<C>>
+ implements RangeSets.Consumer<C> {
+ private final List<RexNode> list;
+ private final RexBuilder rexBuilder;
+ private final RelDataType type;
+ private final SqlTypeName typeName;
+ private final RexNode ref;
Review comment:
If a downstream project have a `Sarg` expression `f0 in ('foo ', 'bar',
'zoo')`, before this patch, the `'foo '` will never be trimmed, is this still
true when we translate `Sarg` to `RexNode` ? If it is not, that would probably
a breaking change because not every engine follow the "Spaces on the ends of
CHAR literals can literally be ignored" rule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
