uschindler commented on pull request #1929: URL: https://github.com/apache/calcite/pull/1929#issuecomment-685665703
Hi, sorry for not producing a useful error message with forbidenapis. The problem here is that forbiddenapis catches a bug (indirectly) that is making Oracle's Javac produce bad class files. After applying the forbiddenapis pull request https://github.com/policeman-tools/forbidden-apis/pull/174 I was able to find the problem: - https://github.com/apache/calcite/blob/29bf6aff96325106756a989297e907daa9e2438d/core/src/main/java/org/apache/calcite/runtime/ResultSetEnumerable.java#L100 - https://github.com/apache/calcite/blob/29bf6aff96325106756a989297e907daa9e2438d/core/src/main/java/org/apache/calcite/runtime/ResultSetEnumerable.java#L439 In both cases javac creates buggy class files which may break downstream consumers of ResultSetEnumerable. My recommendation is to remove the `@Nullable` here. If you want to just work around the issue, you can exclude the file using "exclude" in the forbiddenapis configuration: ``` configureEach<CheckForbiddenApis> { excludeJavaCcGenerated() exclude( "**/org/apache/calcite/adapter/os/Processes${'$'}ProcessFactory.class", "**/org/apache/calcite/adapter/os/OsAdapterTest.class", "**/org/apache/calcite/runtime/Resources${'$'}Inst.class", "**/org/apache/calcite/test/concurrent/ConcurrentTestCommandScript.class", "**/org/apache/calcite/test/concurrent/ConcurrentTestCommandScript${'$'}ShellCommand.class", "**/org/apache/calcite/util/Unsafe.class", "**/org/apache/calcite/runtime/ResultSetEnumerable.class" ) } ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
