rubenada commented on a change in pull request #2131:
URL: https://github.com/apache/calcite/pull/2131#discussion_r482772226
##########
File path: core/src/test/java/org/apache/calcite/test/RelMetadataTest.java
##########
@@ -596,11 +596,11 @@ private void checkExchangeRowCount(RelNode rel, double
expected, double expected
}
@Test void testRowCountRightJoinEmptyFinite() {
- final String sql = "select * from (select * from emp limit 0) as emp\n"
- + "right join (select * from dept limit 4) as dept\n"
+ final String sql = "select * from (select * from emp limit 4) as emp\n"
+ + "right join (select * from dept limit 0) as dept\n"
+ "on emp.deptno = dept.deptno";
checkRowCount(sql, 1D, // 0, rounded up to row count's minimum 1
- 0D, 4D); // 1 * 4
+ 0D, 0D); // 0 * 4
Review comment:
You're right, I have reviewed the test and added more cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
