danny0405 commented on a change in pull request #2130:
URL: https://github.com/apache/calcite/pull/2130#discussion_r483514144
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -11685,6 +11685,19 @@ private void checkCustomColumnResolving(String table) {
+ "MYFUN\\(<NUMERIC>, <NUMERIC>\\).*");
}
+ @Test void testPositionalAggregateWithExpandedCurrentDateFunction() {
+ SqlConformance defaultPlusOrdinalGroupBy =
+ new SqlDelegatingConformance(SqlConformanceEnum.DEFAULT) {
+ @Override public boolean isGroupByOrdinal() {
+ return true;
+ }
+ };
+ sql("SELECT HIREDATE >= CURRENT_DATE, COUNT(*) "
+ + "FROM EMP GROUP BY 1")
Review comment:
> In one place CURRENT_DATE was represented as SqlBasicCall while in
other it was instance of SqlIdentifier
Still does not got your point, in you fix, you just use the expanded group
expr for validation, but the `CURRENT_DATE` is not a group expr ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
