rubenada commented on a change in pull request #2141:
URL: https://github.com/apache/calcite/pull/2141#discussion_r485385731
##########
File path: core/src/main/java/org/apache/calcite/rex/RexCall.java
##########
@@ -80,7 +80,6 @@ protected RexCall(
this.nodeCount = RexUtil.nodeCount(1, this.operands);
assert op.getKind() != null : op;
assert op.validRexOperands(operands.size(), Litmus.THROW) : this;
- assert op.kind != SqlKind.IN || this instanceof RexSubQuery;
Review comment:
@julianhyde IMHO the assertion is a drastic breaking change. As @vlsi
says, what happens with existing applications that may create their own IN
calls (that then are implemented by their own mechanisms / conventions)? Should
this be suddenly unsupported in a minor version upgrade?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
