chunweilei commented on a change in pull request #2145:
URL: https://github.com/apache/calcite/pull/2145#discussion_r486822423
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java
##########
@@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}
public Set<ImmutableBitSet> getUniqueKeys(Aggregate rel, RelMetadataQuery mq,
boolean ignoreNulls) {
- // group by keys form a unique key
- return ImmutableSet.of(rel.getGroupSet());
+ if (Aggregate.isSimple(rel) || ignoreNulls) {
+ // group by keys form a unique key
+ return ImmutableSet.of(rel.getGroupSet());
Review comment:
I don't think so. `rel.getGroupSet()` returns `ImmutableBitSet` while
here we should return `Set<ImmutableBitSet>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
